Change in vdsm[master]: Do not fail when getVSize is called on an inactive LV.

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Feb 3 07:30:34 UTC 2013


Eduardo has posted comments on this change.

Change subject: Do not fail when getVSize is called on an inactive LV.
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/blockVolume.py
Line 94:     @classmethod
Line 95:     def getVSize(cls, sdobj, imgUUID, volUUID, bs=512):
Line 96:         """ Returns size in block units.
Line 97: 
Line 98:         Returns the largest integer value less than or equal to size [blocks].
The calling code adds sometimes a +1 [block] when uses the reported size.
The size calculation was not changed in any way, in spite that this may be beneficial, since it will make the introduction of this patch longer. (Oh my...!).
This patch intended to be a solution for the log issue only.
The docstring was added by requests of the faithful reviewers. It is not changing the math, only describes the behavior.
Line 99:         """
Line 100:         try:
Line 101:             size = _tellEnd(lvm.lvPath(sdobj.sdUUID, volUUID)) / bs
Line 102:         except IOError as e:


--
To view, visit http://gerrit.ovirt.org/9739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list