Change in vdsm[master]: configNet: allow delete/update of devices with no ifcfg
asegurap at redhat.com
asegurap at redhat.com
Sat Feb 2 22:33:21 UTC 2013
Antoni Segura Puimedon has posted comments on this change.
Change subject: configNet: allow delete/update of devices with no ifcfg
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Minus one for visibility of my comment. After explanation I will, in all likelihood, +1 it.
....................................................
File tests/configNetworkTests.py
Line 346: self._assertFilesRestored()
Line 347:
Line 348: def test_getMTUofMissingDev(self):
Line 349: cw = configNetwork.ConfigWriter()
Line 350: self.assertEqual(cw._getDeviceConfigMtu('DEVICE.DOES.NOT.EXIST'), None)
Why the change to assertEqual? The usual comparision to None is "is".
--
To view, visit http://gerrit.ovirt.org/11621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb3a623ca3d3b560288cbe4141eea6bd060ac798
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list