Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

agl at us.ibm.com agl at us.ibm.com
Fri Feb 1 14:39:41 UTC 2013


Adam Litke has posted comments on this change.

Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/netinfo.py
Line 318:                                    'netmask': getnetmask(bridge),
Line 319:                                    'gateway': routes.get(bridge, '0.0.0.0'),
Line 320:                                    'mtu': getMtu(bridge),
Line 321:                                    'cfg': getIfaceCfg(bridge),
Line 322:                                    'bridged': True,
I agree that it seems pretty obvious to a human reader that each of these is bridged.  But requiring that context in clients makes the API hard to use.  I just don't think it makes sense to fragment the types in order to save a single field.  Then clients would receive a NetInfoBridge in one case and a NetInfoBridgeMinusBridged in another case.
Line 323:                                    })
Line 324:                          for bridge in bridges()])
Line 325: 
Line 326:     d['nics'] = dict([(nic, {'speed': speed(nic),


--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list