Change in vdsm[master]: misc: Fix exception re-rasing in RollbackContext
nsoffer at redhat.com
nsoffer at redhat.com
Tue Dec 31 21:45:05 UTC 2013
Nir Soffer has posted comments on this change.
Change subject: misc: Fix exception re-rasing in RollbackContext
......................................................................
Patch Set 2:
(1 comment)
....................................................
File tests/miscTests.py
Line 1140: self.fail("Wrong exception was raised")
Line 1141:
Line 1142: self.fail("Exception was not raised")
Line 1143:
Line 1144: def testKeyErrorException(self):
I think the name of this new test should be testKeyError, as this the name of the tested exception.
Line 1145: """
Line 1146: KeyError is raised as a tuple and not expection. Re-rasing it
Line 1147: should be aware of this fact and handled carfully.
Line 1148: """
--
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list