Change in vdsm[master]: libvirtconnection: Fix a race when starting an eventloop

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 31 16:40:06 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: libvirtconnection: Fix a race when starting an eventloop
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

....................................................
Commit Message
Line 11: 
Line 12: The libvirtEventLoop is counting on the self.run to be true (in the while loop),
Line 13: although the run is only changed to true after this method is called.
Line 14: 
Line 15: The proposed fix was to change the run to true at the beginning of the method
replace "was" with "is"
Line 16: and only change it back to false if we encounter an exception.
Line 17: 
Line 18: Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>


Line 13: although the run is only changed to true after this method is called.
Line 14: 
Line 15: The proposed fix was to change the run to true at the beginning of the method
Line 16: and only change it back to false if we encounter an exception.
Line 17: 
This fix also update self.run to false if the thread exits abnormally.
Line 18: Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>


-- 
To view, visit http://gerrit.ovirt.org/22859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cad0adfdd6c10e173888ee95ef822e1a62f7767
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list