Change in vdsm[master]: sp: improve masterMigrate safety

Federico Simoncelli fsimonce at redhat.com
Tue Dec 31 14:39:24 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: sp: improve masterMigrate safety
......................................................................


Patch Set 2:

(2 comments)

....................................................
File vdsm/storage/sp.py
Line 768:                 self.stopMonitoringDomains()
Line 769:             else:
Line 770:                 futureMaster.releaseClusterLock()
Line 771: 
Line 772:     def switchMasterDomain(self, currentMasterDomain, newMasterDomain,
a lot easier? there are 3 substitutions of s/prevMd/currentMasterDomain/ and 2 substitutions of s/newMD/newMasterDomain/. You can go over them once and if they're correct ignore them later.

Anyway this is a different method (it also has a different signature) I don't think the renaming is so important to deserve its own patch, (e.g. we revert this one but we want to keep the renaming).
Line 773:                            newMasterVersion):
Line 774:         prevPoolMD = self._getPoolMD(currentMasterDomain)
Line 775:         domains = prevPoolMD[PMDK_DOMAINS]
Line 776:         pool_descr = prevPoolMD[PMDK_POOL_DESCRIPTION]


Line 869:                 newmsd.unmountMaster()
Line 870:             except:  # logging only
Line 871:                 self.log.error('unable to unmount master filesystem '
Line 872:                                'for domain %s', newmsd.sdUUID)
Line 873:             newmsd.releaseClusterLock()
Done
Line 874:             raise
Line 875: 
Line 876:         # From this point on we have a new master and should not fail
Line 877:         try:


-- 
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list