Change in vdsm[master]: Add --run-again option to upgrades

amuller at redhat.com amuller at redhat.com
Tue Dec 31 10:03:43 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Add --run-again option to upgrades
......................................................................


Patch Set 1:

(3 comments)

....................................................
File lib/vdsm/tool/upgrade.py
Line 117:         self._detachUpgradeLog()
Line 118: 
Line 119: 
Line 120: def _parse_args():
Line 121:     parser = argparse.ArgumentParser('vdsm-tool')
Done
Line 122:     parser.add_argument(
Line 123:         '--force',
Line 124:         dest='force',
Line 125:         default=False,


Line 125:         default=False,
Line 126:         action='store_true',
Line 127:         help='Run the upgrade again, even if it was ran before',
Line 128:     )
Line 129:     return parser.parse_args(sys.argv[2:])
Sorry I'm not following - The upgrades should and can only be called via vdsm-tool?
Line 130: 
Line 131: 
Line 132: def upgrade(upgradeName):
Line 133:     """


....................................................
File lib/vdsm/tool/upgrade_300_networks.py
Line 64:     """
Line 65:     networks = netinfo.networks()
Line 66:     bridges = netinfo.bridges()
Line 67: 
Line 68:     if isNeeded(networks, bridges):
I wanted an option that could skip the upgrade file check, but wouldn't meddle with an upgrade's logic. I'll rename the option.


-- 
To view, visit http://gerrit.ovirt.org/22750
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e6b84bdd14b9cd3921cea187b2654be22989334
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list