Change in vdsm[master]: hooks: Security groups support for OVS

amuller at redhat.com amuller at redhat.com
Tue Dec 31 08:13:53 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: hooks: Security groups support for OVS
......................................................................


Patch Set 1:

(2 comments)

....................................................
File lib/vdsm/constants.py.in
Line 101: 
Line 102: EXT_IFDOWN = '@IFDOWN_PATH@'
Line 103: EXT_IFUP = '@IFUP_PATH@'
Line 104: EXT_IONICE = '@IONICE_PATH@'
Line 105: EXT_IP = '@IP_PATH@'
It's used in lib/vdsm/ipwrapper.py, take a look.
Line 106: EXT_ISCSIADM = '@ISCSIADM_PATH@'
Line 107: EXT_TC = '@TC_PATH@'
Line 108: 
Line 109: EXT_KILL = '@KILL_PATH@'


....................................................
File vdsm_hooks/openstacknet/before_device_create.py
Line 94: 
Line 95:     vethBr = devName("qvb", portId)
Line 96:     vethOvs = devName("qvo", portId)
Line 97: 
Line 98:     if not checkDeviceExists(vethOvs):
How about using ipwrapper.py here?
Line 99:         executeOrExit([EXT_IP, 'link', 'add', vethBr, 'type', 'veth', 'peer',
Line 100:                       'name', vethOvs])
Line 101:         for dev in [vethBr, vethOvs]:
Line 102:             executeOrExit([EXT_IP, 'link', 'set', dev, 'up'])


-- 
To view, visit http://gerrit.ovirt.org/22585
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77e219cce9c572ebef6a8584847f517abbda224d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list