Change in vdsm[master]: vm: janitorial: introduce a recovering attribute.

fromani at redhat.com fromani at redhat.com
Mon Dec 30 10:01:35 UTC 2013


Francesco Romani has posted comments on this change.

Change subject: vm: janitorial: introduce a recovering attribute.
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/vm.py
Line 1786:         :param params: The VM parameters.
Line 1787:         :type params: dict
Line 1788:         """
Line 1789:         self._dom = None
Line 1790:         self.recovering = params.pop('recover', False)
Yep no problem at all. I was actually tempted to do that since the begninning.
Line 1791:         self.conf = {'pid': '0'}
Line 1792:         self.conf.update(params)
Line 1793:         self.cif = cif
Line 1794:         self.log = SimpleLogAdapter(self.log, {"vmId": self.conf['vmId']})


-- 
To view, visit http://gerrit.ovirt.org/22783
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a43c5f6427c81a6610d820d9475b375c8dc0947
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list