Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

danken at redhat.com danken at redhat.com
Wed Dec 25 19:04:38 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: link monitor: do not leave stray `ip monitor` behind
......................................................................


link monitor: do not leave stray `ip monitor` behind

ipwrapper.Monitor.start() spawns an `ip monitor link` process that may
run forever. If Vdsm crashes, we should take care to kill it, or it
would leak.

Due to this patch, ipwrapper.Monitor.start() should be called from an
ever-lasting thread.

Change-Id: Icb1f8998a3f71046c28bf902c851bf900b1e6f7f
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22667
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/utils.py
2 files changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22667
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb1f8998a3f71046c28bf902c851bf900b1e6f7f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list