Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

abaron at redhat.com abaron at redhat.com
Wed Dec 25 09:54:21 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk
......................................................................


Patch Set 6:

(1 comment)

....................................................
File vdsm/clientIF.py
Line 266:                 res = self.irs.appropriateDevice(drive["GUID"], vmId)
Line 267:                 if res['status']['code']:
Line 268:                     raise vm.VolumeError(drive)
Line 269: 
Line 270:                 volPath = os.path.join("/dev/mapper", drive["GUID"])
I still want another patch that makes clientIF agnostic to the implementation detail that we rely on /dev/mapper
Line 271: 
Line 272:             # UUID drive format
Line 273:             elif "UUID" in drive:
Line 274:                 volPath = self._getUUIDSpecPath(drive["UUID"])


-- 
To view, visit http://gerrit.ovirt.org/21181
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list