Change in vdsm[master]: netconf: enable multiple gateways for iproute2 configurator
amuller at redhat.com
amuller at redhat.com
Tue Dec 24 19:16:23 UTC 2013
Assaf Muller has posted comments on this change.
Change subject: netconf: enable multiple gateways for iproute2 configurator
......................................................................
Patch Set 7:
(1 comment)
....................................................
File vdsm/netconf/iproute2.py
Line 153: if ipConfig.ipaddr:
Line 154: try:
Line 155: self.removeIpConfig(iface)
Line 156: ipwrapper.addrAdd(iface.name, ipConfig.ipaddr,
Line 157: ipConfig.netmask)
Need to test if 'dev' is a required parameter in this context.
Line 158: if ipConfig.gateway and ipConfig.defaultRoute:
Line 159: ipwrapper.routeAdd(['default', 'via', ipConfig.gateway])
Line 160: except ipwrapper.IPRoute2Error as e:
Line 161: if 'File exists' in e.message[0]:
--
To view, visit http://gerrit.ovirt.org/16276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76e1225caffdb2de3073041e541c7c978eefb396
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list