Change in vdsm[master]: Fix assert bug in testBrokenBridgelessNetReplacement

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue Dec 24 13:39:32 UTC 2013


Mark Wu has uploaded a new change for review.

Change subject: Fix assert bug in testBrokenBridgelessNetReplacement
......................................................................

Fix assert bug in testBrokenBridgelessNetReplacement

If the underlying device is missing, vdsm will not report
the network, but its config in vdsm is still there before
the broken network is removed.

Change-Id: Ie15ae32d83dbc771c675306b9aa8816162e9d7e3
Signed-off-by: Mark Wu <wudxw at linux.vnet.ibm.com>
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/22710/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 45bfaa5..a2096af 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1635,7 +1635,7 @@
             self.assertNetworkExists(NETWORK_NAME)
             ipwrapper.linkDel(nic + '.' + VLAN_ID)
             self.vdsm_net.refreshNetinfo()
-            self.assertNetworkDoesntExist(NETWORK_NAME)
+            self.assertNotIn(NETWORK_NAME, self.vdsm_net.netinfo.networks)
             status, msg = self.vdsm_net.setupNetworks(network, {},
                                                       {'connectivityCheck': 0})
             self.assertEqual(status, SUCCESS, msg)


-- 
To view, visit http://gerrit.ovirt.org/22710
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie15ae32d83dbc771c675306b9aa8816162e9d7e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list