Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

dnarayan at redhat.com dnarayan at redhat.com
Tue Dec 24 09:59:46 UTC 2013


Hello Bala.FA,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/22693

to review the following change.

Change subject: gluster: additional parsing of host UUID in verb glusterVolumesList
......................................................................

gluster: additional parsing of host UUID in verb glusterVolumesList

This patch adds parsing of host UUID for all the bricks in the
verb glusterVolumesList.

Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1038988
Signed-off-by: ndarshan <dnarayan at redhat.com>
---
M vdsm/gluster/cli.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/22693/1

diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 167f01c..44d82dc 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -353,10 +353,10 @@
             value['transportType'] = [TransportType.RDMA]
         else:
             value['transportType'] = [TransportType.TCP, TransportType.RDMA]
-        value['bricks'] = []
+        value['bricks'] = {}
         value['options'] = {}
         for b in el.findall('bricks/brick'):
-            value['bricks'].append(b.text)
+            value['bricks'][b.text] = b.get('uuid')
         for o in el.findall('options/option'):
             value['options'][o.find('name').text] = o.find('value').text
         volumes[value['volumeName']] = value


-- 
To view, visit http://gerrit.ovirt.org/22693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>


More information about the vdsm-patches mailing list