Change in vdsm[master]: tests: janitorial: cleanup temporary directories

danken at redhat.com danken at redhat.com
Mon Dec 23 22:48:30 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: tests: janitorial: cleanup temporary directories
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

....................................................
File tests/hooksTests.py
Line 101:         os.unlink(sName)
Line 102:         self.assertEqual({'md5': md5}, info)
Line 103: 
Line 104:     @contextmanager
Line 105:     def _namedTemporaryDir(self):
good idea. `git grep mkdtemp` to see why this should be public and sit in testrunner (you do not need to clean all of them in one patch).
Line 106:         tmpDir = tempfile.mkdtemp()
Line 107:         try:
Line 108:             yield tmpDir
Line 109:         finally:


-- 
To view, visit http://gerrit.ovirt.org/22377
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6581771479de9f72360ea537de32abcdad496b3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list