Change in vdsm[master]: sp: _refreshDomainLinks must not change the metadata

Federico Simoncelli fsimonce at redhat.com
Mon Dec 23 13:27:25 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: sp: _refreshDomainLinks must not change the metadata
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 218:                 continue
Line 219: 
Line 220:             try:
Line 221:                 self.setDomainRegularRole(domain)
Line 222:             except:
This is here to ensure that we can start the spm even with a domain that is flaky. If we're able to fetch its role (line 216) we should be able to set its role here. If it fails the domain is probably unreachable now. I wouldn't fail hard on this. Its role will be fixed asap.
Line 223:                 self.log.exception('Unable to set role for domain %s', sdUUID)
Line 224: 
Line 225:     @unsecured
Line 226:     def startSpm(self, prevID, prevLVER, scsiFencing, maxHostID,


-- 
To view, visit http://gerrit.ovirt.org/22131
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ecf801d58b34c1c811e311e3779887a406af5f0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list