Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 22 23:01:59 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: remoteFileHandler: Remove harmful libvirt dependency
......................................................................


Patch Set 2:

> I do not quite understand what is the charter of the new "host.py" module. Does it have any definition beyond "the part of caps which oop needs"? 

In the current form, your definition is precise :-)

> Its name is too general, too.

The motivation for the name is simply:

    import host
    if host.isOvirtNode():
        ....
 
> I'd like to understand the planned boundary between host.py and caps.py.

In the final form, host can include anything which is related to host info, while caps can be responsible for building a capabilities response from host and libvirtconnection modules.

But in this form, host will include lot of stuff that remoteFileHandler does not need. This is way I abandoned this patch.

-- 
To view, visit http://gerrit.ovirt.org/22316
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list