Change in vdsm[master]: network_func_tests: Fix broken networks regression test for ...

amuller at redhat.com amuller at redhat.com
Sun Dec 22 08:11:28 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: network_func_tests: Fix broken networks regression test for unified persistence
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Nitpicking.

....................................................
Commit Message
Line 16: The catch is that the filtering of broken networks is only done on
Line 17: netinfo since it is there that we fail to retrieve the information
Line 18: due to the missing device. This patch fixes it by making the test
Line 19: not check runningConfig. I don't believe we should fix this by
Line 20: adding filtering to runningConfig, at least I can't see how and
convincet -> convinced
Line 21: I'm not convincet yet of the why.
Line 22: 
Line 23: Change-Id: I8c636f95fea07ae7988c9ecddf04284b8d5a0037


....................................................
File tests/functional/networkTests.py
Line 170:             with RollbackContext() as rollback:
Line 171:                 rollback.prependDefer(args[0].vdsm_net.restoreNetConfig)
Line 172:                 func(*args, **kwargs)
Line 173:         return wrapper
Line 174: 
What about an identical addition to assertNetworkExists?
Line 175:     def assertNetworkExists(self, networkName, bridged=None):
Line 176:         netinfo = self.vdsm_net.netinfo
Line 177:         config = self.vdsm_net.config
Line 178:         self.assertIn(networkName, netinfo.networks)


-- 
To view, visit http://gerrit.ovirt.org/22610
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c636f95fea07ae7988c9ecddf04284b8d5a0037
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list