Change in vdsm[master]: ipwrapper: fix excessive process creation

asegurap at redhat.com asegurap at redhat.com
Fri Dec 20 23:36:42 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: ipwrapper: fix excessive process creation
......................................................................


Patch Set 1: Verified-1

On one of my hosts there is a functional test that fails. I'll investigate this further.

    NetworkTest
        testAddDelBondedNetwork(kwargs=False)                       OK
        testAddDelBondedNetwork(kwargs=True)                        OK
        testAddDelNetwork(kwargs=False)                             OK
        testAddDelNetwork(kwargs=True)                              OK
        testAddNetworkBondWithManyVlans(kwargs=False)               OK
        testAddNetworkBondWithManyVlans(kwargs=True)                OK
        testAddNetworkManyVlans(kwargs=False)                       OK
        testAddNetworkManyVlans(kwargs=True)                        OK
        testAddNetworkVlan(kwargs=False)                            OK
        testAddNetworkVlan(kwargs=True)                             OK
        testAddNetworkVlanBond(kwargs=False)                        OK
        testAddNetworkVlanBond(kwargs=True)                         OK
        testAddVlanedBridgeless                                     OK
        testAddVlanedBridgeless_oneCommand                          OK
        testAfterNetworkSetupHook                                   OK
        testBeforeNetworkSetupHook                                  OK
        testBondHwAddress(kwargs=False)                             OK
        testBondHwAddress(kwargs=True)                              OK
        testBrokenBridgelessNetReplacement                          FAIL

    ======================================================================
    FAIL: testBrokenBridgelessNetReplacement (networkTests.NetworkTest)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/root/code/vdsm/tests/testValidation.py", line 114, in wrapper
        return f(*args, **kwargs)
      File "/root/code/vdsm/tests/testValidation.py", line 99, in wrapper
        return f(*args, **kwargs)
      File "/root/code/vdsm/tests/functional/networkTests.py", line 1638, in testBrokenBridgelessNetReplacement
        self.assertNetworkDoesntExist(NETWORK_NAME)
      File "/root/code/vdsm/tests/functional/networkTests.py", line 190, in assertNetworkDoesntExist
        self.assertNotIn(networkName, self.vdsm_net.config.networks)
      File "/root/code/vdsm/tests/testrunner.py", line 192, in assertNotIn
        raise self.failureException(msg)
    AssertionError: 'test-network' unexpectedly found in {'test-network': {u'nic': u'dummy_36', u'vlan': u'27', u'bridged': False}}
    -------------------- >> begin captured logging << --------------------
    root: DEBUG: '/sbin/ip link del dev dummy_36.27' (cwd None)
    root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
    --------------------- >> end captured logging << ---------------------

    ----------------------------------------------------------------------
    Ran 19 tests in 70.061s

    FAILED (failures=1)

-- 
To view, visit http://gerrit.ovirt.org/22609
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8de502669dfa00585d8d775f51be5617cd4f63d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list