Change in vdsm[master]: linkmonitor: fix reported device name of vlans and macvlans

danken at redhat.com danken at redhat.com
Fri Dec 20 16:45:24 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: linkmonitor: fix reported device name of vlans and macvlans
......................................................................


linkmonitor: fix reported device name of vlans and macvlans

Previously, vlans and macvlans would get the event name reported as:
- 'foo at bar', where bar is the device the foo macvlan sits on.
- 'bond777.555 at bond777', where bond777 is the device the 555 vlan
  sits on.

After this fix, both devices would be properly reported as:
- foo
- bond777.555

Since we use the ifindex, we'll add it to the event.

Change-Id: Ieaeab6adc30a80b70e9e967768c10b3fea65aa16
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22061
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/ipwrapper.py
M tests/ipwrapperTests.py
2 files changed, 70 insertions(+), 27 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22061
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaeab6adc30a80b70e9e967768c10b3fea65aa16
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list