Change in vdsm[master]: vm: janitorial: factorize key deletion in Vm.conf

danken at redhat.com danken at redhat.com
Fri Dec 20 11:54:01 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vm: janitorial: factorize key deletion in Vm.conf
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/vm.py
Line 2483:             self._underlyingCont()
Line 2484:             if hasattr(self, 'updateGuestCpuRunning'):
Line 2485:                 self.updateGuestCpuRunning()
Line 2486:             self._lastStatus = afterState
Line 2487:             self._delConfKey('pauseCode')
I believe that there are (or were?) cases where cont() is called on an already-running VM. Such cases would not have 'pauseCode', and explode with a KeyError.

Removing the alarming "except: pass" clause is noble. But it requires close verification. Has such been done?
Line 2488:             return {'status': doneCode, 'output': ['']}
Line 2489:         finally:
Line 2490:             if not guestCpuLocked:
Line 2491:                 self._guestCpuLock.release()


-- 
To view, visit http://gerrit.ovirt.org/22556
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5a3da3fea0346f5f75c2f9d60c995aaf7214c6d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list