Change in vdsm[master]: tests: janitorial: cleanup temporary directories

fromani at redhat.com fromani at redhat.com
Fri Dec 20 11:05:42 UTC 2013


Francesco Romani has posted comments on this change.

Change subject: tests: janitorial: cleanup temporary directories
......................................................................


Patch Set 3:

(2 comments)

....................................................
File tests/hooksTests.py
Line 110:             expectedRes = dict([(os.path.basename(sName), {'md5': md5})])
Line 111:             self.assertEqual(expectedRes, info)
Line 112:         finally:
Line 113:             os.unlink(sName)
Line 114:             NEscript.close()
You're right. Proper fix coming soon.
Line 115:             os.rmdir(dir)
Line 116: 
Line 117:     def _deviceCustomPropertiesTestFile(self):
Line 118:         dirName = tempfile.mkdtemp()


Line 132:         return dirName
Line 133: 
Line 134:     def test_deviceCustomProperties(self):
Line 135:         try:
Line 136:             dirName = self._deviceCustomPropertiesTestFile()
Will fix.
Line 137: 
Line 138:             result = hooks._runHooksDir("oVirt", dirName,
Line 139:                                         params={'customProperty': ' rocks!'})
Line 140:             self.assertEqual(result, "oVirt rocks!")


-- 
To view, visit http://gerrit.ovirt.org/22377
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6581771479de9f72360ea537de32abcdad496b3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list