Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

danken at redhat.com danken at redhat.com
Thu Dec 19 18:16:19 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: include HWADDR line only if NM is around
......................................................................


Patch Set 3:

(1 comment)

....................................................
File lib/vdsm/config.py.in
Line 43:             'be shown to vdsm.'),
Line 44: 
Line 45:         ('persistence', 'ifcfg',
Line 46:             'Whether to use "ifcfg" or "unified" persistence for networks.'),
Line 47: 
With this option, users who know that they have turned nm off temporarily, can still be "nm-ready" by setting this configurable.

However, when I think of it, it's not that apparent. Would a third state "never" would help?
Line 48:         ('hwaddr_in_ifcfg', 'nm',
Line 49:             'Whether to set HWADDR in ifcfg files only when NetworkManager is '
Line 50:             'running ("nm"), or "always".'),
Line 51: 


-- 
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list