Change in vdsm[master]: Introduce a maximum time limit a migration may take

fromani at redhat.com fromani at redhat.com
Thu Dec 19 11:50:27 UTC 2013


Francesco Romani has posted comments on this change.

Change subject: Introduce a maximum time limit a migration may take
......................................................................


Patch Set 7:

(1 comment)

....................................................
File vdsm/vm.py
Line 787:                 # Migration is stuck, abort
Line 788:                 self._vm.log.warn(
Line 789:                     'Migration is stuck: Hasn\'t progressed in %s seconds. '
Line 790:                     'Aborting.' % (time.time() - lastProgressTime))
Line 791:                 abort = True
Yes. At first glance looked to me like an acceptable change, but on second thought, whether good or not, I think it deserves a separate change.
Line 792: 
Line 793:             if abort:
Line 794:                 self._vm._dom.abortJob()
Line 795:                 self.stop()


-- 
To view, visit http://gerrit.ovirt.org/21708
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2f76b9334fcb7d2db24c081cccae15e8fd0b0c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list