Change in vdsm[master]: vm: Avoid log spamming when drive format is undefined

danken at redhat.com danken at redhat.com
Wed Dec 18 23:56:54 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vm: Avoid log spamming when drive format is undefined
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/vm.py
Line 1406:     def isDiskReplicationInProgress(self):
Line 1407:         return hasattr(self, "diskReplicate")
Line 1408: 
Line 1409:     def isExtendable(self):
Line 1410:         # Note: format may not be defined during migration
on migration destination, I suppose.
Line 1411:         return self.blockDev and getattr(self, 'format', None) == 'cow'
Line 1412: 
Line 1413:     @property
Line 1414:     def volExtensionChunk(self):


-- 
To view, visit http://gerrit.ovirt.org/22551
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50e8af94b9c9b54332066a3f30999ce73e7a56f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list