Change in vdsm[master]: vmDevices: add __slots__ to devices

Federico Simoncelli fsimonce at redhat.com
Wed Dec 18 21:07:59 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: vmDevices: add __slots__ to devices
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/vm.py
Line 1144:         return self.doc.toprettyxml(encoding='utf-8')
Line 1145: 
Line 1146: 
Line 1147: class VmDevice(object):
Line 1148:     __slots__ = ['deviceType', 'device', 'alias', 'specParams', 'deviceId']
Please use tuples as they're cheaper.
Line 1149: 
Line 1150:     def __init__(self, conf, log, **kwargs):
Line 1151:         self.specParams = {}
Line 1152:         for attr, value in kwargs.iteritems():


-- 
To view, visit http://gerrit.ovirt.org/21036
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list