Change in vdsm[master]: upgrade.log now owned by vdsm:kvm

danken at redhat.com danken at redhat.com
Wed Dec 18 10:23:09 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: upgrade.log now owned by vdsm:kvm
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

....................................................
File lib/vdsm/tool/upgrade.py
Line 61:                                       disable_existing_loggers=False)
Line 62:             chown(
Line 63:                 os.path.join(P_VDSM_LOG, 'upgrade.log'),
Line 64:                 VDSM_USER,
Line 65:                 VDSM_GROUP)
there are many others reasons that chown may fail (think selinux). We cannot "ask for permission" ahead of time, we must "ask for forgiveness" if we fail.
Line 66:         except Exception:
Line 67:             logging.getLogger('upgrade').addHandler(SysLogHandler('/dev/log'))
Line 68:             logging.exception("Could not init proper logging")
Line 69:         finally:


-- 
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list