Change in vdsm[master]: set reconfigureOnForce attribute to ModuleConfigurer

Alon Bar-Lev alonbl at redhat.com
Tue Dec 17 20:03:44 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: set reconfigureOnForce attribute to ModuleConfigurer
......................................................................


Patch Set 2:

(2 comments)

....................................................
File lib/vdsm/tool/configurator.py
Line 47:     def isconfigured(self):
Line 48:         return True
Line 49: 
Line 50:     def reconfigureOnForce(self):
Line 51:         return False
I think that default should be True only special cases it is false.
Line 52: 
Line 53: 
Line 54: class LibvirtModuleConfigure(_ModuleConfigure):
Line 55:     def __init__(self):


Line 178:         return ret
Line 179: 
Line 180:     def reconfigureOnForce(self):
Line 181:         return False
Line 182: 
no need to override base if same
Line 183: 
Line 184: __configurers = (
Line 185:     LibvirtModuleConfigure(),
Line 186:     SanlockModuleConfigure(),


-- 
To view, visit http://gerrit.ovirt.org/22492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list