Change in vdsm[master]: vdsm-tool: add node registration tool

ybronhei at redhat.com ybronhei at redhat.com
Tue Dec 17 19:40:20 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: add node registration tool
......................................................................


Patch Set 4:

(4 comments)

....................................................
File lib/vdsm/tool/ovirt-node-registration.py
Line 124:                 break
Line 125:     return ret
Line 126: 
Line 127: 
Line 128: def get_remote_public_ssh_key(url):
private with _
Line 129:     """Get public key from determined url
Line 130: 
Line 131:     Args
Line 132:     url -- URL to download the ssh key


Line 272:         help='Add ovirt engine public ssh key to node authorized keys',
Line 273:     )
Line 274: 
Line 275:     parser.add_argument(
Line 276:         '--enable-log',
without this we don't have output at all? why not to do standard --verbose/-v which use stdout and stderr for outputs
Line 277:         action='store_true',
Line 278:         help="Creates a log file during the execution"
Line 279:     )
Line 280: 


Line 382:         node_hostname = socket.gethostname()
Line 383: 
Line 384:     management_port = args.node_management_port
Line 385:     if management_port is None:
Line 386:         management_port = 54321
put default constants
Line 387: 
Line 388:     node_management_address = args.node_management_address
Line 389:     if node_management_address is None:
Line 390:         route = routeGet([urlparse.urlparse(args.url).hostname])[0]


Line 407:                 management_port
Line 408:             )
Line 409:         )
Line 410:     else:
Line 411:         raise RuntimeError('Cannot complete the registration')
should return True on success
Line 412: 
Line 413: if __name__ == '__main__':


-- 
To view, visit http://gerrit.ovirt.org/22494
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list