Change in vdsm[master]: Setting force to true overwrites the configuration in libvir...

Alon Bar-Lev alonbl at redhat.com
Tue Dec 17 17:55:47 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Setting force to true overwrites the configuration in libvirt configurer
......................................................................


Patch Set 1:

(1 comment)

....................................................
File lib/vdsm/tool/configurator.py
Line 43: 
Line 44:     def configure(self):
Line 45:         pass
Line 46: 
Line 47:     def isconfigured(self, force):
why not add a new method? something like reconfigureIfForce? this will reduce the spaghetti return at middle and be more clear.
Line 48:         return True
Line 49: 
Line 50: 
Line 51: class LibvirtModuleConfigure(_ModuleConfigure):


-- 
To view, visit http://gerrit.ovirt.org/22492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list