Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 17 17:28:01 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: clientIF: Teardown volume path only for VDSM images
......................................................................


Patch Set 5:

I suggest again to rebase this on http://gerrit.ovirt.org/22370, which simplify the handling of drive object in vm.isVdsmImage.

Supporting string and None types can be solve either in isVdsmImage or in teardownVolumePath. Since these types are not compatible with vm.Drive or dict, I don't think we should support them in vm.isVdsmImage. The best way would be to let isVdsmImage raise TypeError when sending str or None, and catch that error in clientIF.teardownVolumePath.

-- 
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list