Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around
danken at redhat.com
danken at redhat.com
Tue Dec 17 17:04:56 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/netconf/ifcfg.py
Line 612:
Line 613: def addNic(self, nic, **opts):
Line 614: """ Create ifcfg-* file with proper fields for NIC """
Line 615: _netinfo = netinfo.NetInfo()
Line 616: conf = ''
I do not care about this edge case. I'll add a clearer warning about it in the commit message.
Line 617: if _hwaddr_required():
Line 618: hwaddr = (_netinfo.nics[nic.name].get('permhwaddr') or
Line 619: _netinfo.nics[nic.name]['hwaddr'])
Line 620:
--
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list