Change in vdsm[master]: sp: consolidate getMasterVersion in one method

mlipchuk at redhat.com mlipchuk at redhat.com
Tue Dec 17 12:37:26 UTC 2013


Maor Lipchuk has posted comments on this change.

Change subject: sp: consolidate getMasterVersion in one method
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 835:     def masterMigrate(self, sdUUID, msdUUID, masterVersion):
Line 836:         self.log.info("sdUUID=%s spUUID=%s msdUUID=%s", sdUUID, self.spUUID,
Line 837:                       msdUUID)
Line 838: 
Line 839:         # TODO: is this check still relevant?
Maybe it's worth to also keep the comment that was in validatePoolMVerHigher before ("Make sure the masterVersion....")
Line 840:         if not masterVersion > self.getMasterVersion():
Line 841:             raise se.StoragePoolWrongMaster(self.spUUID,
Line 842:                                             self.masterDomain.sdUUID)
Line 843: 


-- 
To view, visit http://gerrit.ovirt.org/22130
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a055c9eb21cc5681d1f9afde5e7eab899aa65c0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list