Change in vdsm[master]: build: Forbid bare except:

smizrahi at redhat.com smizrahi at redhat.com
Tue Dec 17 12:03:28 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: build: Forbid bare except:
......................................................................


Patch Set 3:

disregarding the fact that creating false positive that breaks the build is extremely easy.

Having a documentation file that says:

You are allowed to do stuff
except:
1. A

Would break the build.

Also I think you meant to use git diff and not git show.

Further more since it only really works for Jenkins it should be a Jenkins job. Having it in the build would only annoy people while they are developing and create weird situations since not all is comitted and sometimes people commit broken code locally.

-- 
To view, visit http://gerrit.ovirt.org/22456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list