Change in vdsm[master]: build: Forbid bare exepct

asegurap at redhat.com asegurap at redhat.com
Tue Dec 17 10:22:06 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: build: Forbid bare exepct
......................................................................


Patch Set 1:

(1 comment)

....................................................
File Makefile.am
Line 78: SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
Line 79: 	'lv' from line .*"
Line 80: 
Line 81: check-local:
Line 82: 	if git show | grep 'except:'; then \
grep returns 0 when found and 1 otherwise. Shouldn't you exit and show error in the "0" case.
Line 83: 		echo "error: empty except: is not allowed!"; \
Line 84: 		exit 1; \
Line 85: 	fi
Line 86: 	find . -path './.git' -prune -type f -o \


-- 
To view, visit http://gerrit.ovirt.org/22456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list