Change in vdsm[master]: build: Forbid bare exepct

asegurap at redhat.com asegurap at redhat.com
Tue Dec 17 10:20:39 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: build: Forbid bare exepct
......................................................................


Patch Set 1:

(1 comment)

....................................................
Commit Message
Line 3: AuthorDate: 2013-12-17 12:14:23 +0200
Line 4: Commit:     Nir Soffer <nsoffer at redhat.com>
Line 5: CommitDate: 2013-12-17 12:14:23 +0200
Line 6: 
Line 7: build: Forbid bare exepct
s/exepct/except/
Line 8: 
Line 9: Using bare except is bad practice and is never required. We should
Line 10: disallow this in new code. This patch ensure that your build will break
Line 11: if your patch added a bare except.


-- 
To view, visit http://gerrit.ovirt.org/22456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list