Change in vdsm[master]: upgrade.log now owned by vdsm:kvm

danken at redhat.com danken at redhat.com
Mon Dec 16 21:03:06 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: upgrade.log now owned by vdsm:kvm
......................................................................


Patch Set 3:

(1 comment)

....................................................
File lib/vdsm/tool/upgrade.py
Line 60:                                       disable_existing_loggers=False)
Line 61:             uid = pwd.getpwnam(VDSM_USER)[2]
Line 62:             gid = grp.getgrnam(VDSM_GROUP)[2]
Line 63:             cmd = [EXT_CHOWN, "%s:%s" % (uid, gid),
Line 64:                    os.path.join(P_VDSM_LOG, 'upgrade.log')]
There is an alternative: put root-owned logs in update.log, and vdsm-owned ones in the usual vdsm.log.

Having all upgrade-related logs in one file is a nice goal, but I don't think it worth so much logging witchcraft. 

Another alternative is using a syslog handler for upgrade by all processes instead of a file.
Line 65:             (rc, out, err) = execCmd(cmd, sudo=True)
Line 66:             if rc != 0:
Line 67:                 raise IOError(err)
Line 68:         except Exception:


-- 
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list