Change in vdsm[ovirt-3.3]: Changed BrokerLink log level to prevent log flooding

jmoskovc at redhat.com jmoskovc at redhat.com
Mon Dec 16 15:00:32 UTC 2013


Hello Martin Sivák, Doron Fediuck, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/22424

to review the following change.

Change subject: Changed BrokerLink log level to prevent log flooding
......................................................................

Changed BrokerLink log level to prevent log flooding

- vdsm imports the BrokerLink lib with ovirt_hosted_engine_ha,
  unfortunatelly it's logger generates a lot of debug output
  in the default configuration, so this patch sets the level
  of the whole ovirt_hosted_engine_ha package to ERROR
  to limit the amount of the logs

- NOTE: this patch needs some changes in the ovirt_hosted_engine_ha
  logging, without these changes it does not have any
  effect

Depends-On: I40fb7aca813800dd445e858406034736817cac9c
Change-Id: Icc470175d785d216fe75837e5cb3572adf340fe6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1040884
Signed-off-by: Jiri Moskovcak <jmoskovc at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21947
Reviewed-by: Martin Sivák <msivak at redhat.com>
Reviewed-by: Doron Fediuck <dfediuck at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/logger.conf.in
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/22424/1

diff --git a/vdsm/logger.conf.in b/vdsm/logger.conf.in
index 824e169..e7ff032 100644
--- a/vdsm/logger.conf.in
+++ b/vdsm/logger.conf.in
@@ -1,5 +1,5 @@
 [loggers]
-keys=root,vds,Storage,metadata
+keys=root,vds,Storage,metadata,ovirt_hosted_engine_ha
 
 [handlers]
 keys=console,syslog,logfile,metadata
@@ -30,6 +30,12 @@
 qualname=irs.metadata
 propagate=0
 
+[logger_ovirt_hosted_engine_ha]
+level=ERROR
+handlers=
+qualname=ovirt_hosted_engine_ha
+propagate=1
+
 [handler_syslog]
 level=WARNING
 class=handlers.SysLogHandler


-- 
To view, visit http://gerrit.ovirt.org/22424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc470175d785d216fe75837e5cb3572adf340fe6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Jiří Moskovčák <jmoskovc at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>


More information about the vdsm-patches mailing list