Change in vdsm[master]: sp: consolidate getMasterVersion in one method
Federico Simoncelli
fsimonce at redhat.com
Mon Dec 16 10:55:45 UTC 2013
Federico Simoncelli has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/storage/sp.py
Line 489:
Line 490: @unsecured
Line 491: def getMasterVersion(self, useMasterDomain=None):
Line 492: domain = (self.masterDomain
Line 493: if useMasterDomain is None else useMasterDomain)
Because this will end up in the backend API interface and I don't want to have multiple methods for the same action. Also _getMasterVersionFromDomain won't be private since we'll have to call it from this class.
Line 494: return self._getPoolMD(domain)[PMDK_MASTER_VER]
Line 495:
Line 496: def setDomainMasterRole(self, domain, role, masterVersion):
Line 497: poolMeta = self._getPoolMD(domain)
--
To view, visit http://gerrit.ovirt.org/22130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a055c9eb21cc5681d1f9afde5e7eab899aa65c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list