Change in vdsm[master]: vdsClient: new option to show VDSM configuration

danken at redhat.com danken at redhat.com
Sun Dec 15 12:59:08 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsClient: new option to show VDSM configuration
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
Commit Message
Line 6: 
Line 7: vdsClient: new option to show VDSM configuration
Line 8: 
Line 9: The goal for the new option showConfig is show to users
Line 10: the current settings in vdsm.conf.
Why is this any better than

  less /etc/vdsm/vdsm.conf?

Why is it part of vdsClient while it can run only at the server side?
Line 11: 
Line 12: Change-Id: I81c3f2d2588d3963c66bad42e469e78f1393104b


-- 
To view, visit http://gerrit.ovirt.org/21876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81c3f2d2588d3963c66bad42e469e78f1393104b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list