Change in vdsm[master]: deactivateSD - perform nothing if the domain is already deac...

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 15 11:38:36 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: deactivateSD - perform nothing if the domain is already deactivated
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 1143: 
Line 1144:         if sdUUID not in domList:
Line 1145:             raise se.StorageDomainNotInPool(self.spUUID, sdUUID)
Line 1146: 
Line 1147:         if domList[sdUUID] == sd.DOM_ATTACHED_STATUS:
Sergey: please be clear why you object to this patch - is this the silent ignore, or your fear of incorrect code? If you think that that if *is* wrong please show us how it is wrong.
Line 1148:             return True
Line 1149: 
Line 1150:         try:
Line 1151:             dom = sdCache.produce(sdUUID)


-- 
To view, visit http://gerrit.ovirt.org/22343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I927557637cc6588dae832427018f6ac304f0a562
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list