Change in vdsm[ovirt-3.3]: vdsm: prepareVolumePath correct path handling for cdrom
danken at redhat.com
danken at redhat.com
Sat Dec 14 08:53:39 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File vdsm/clientIF.py
Line 306: elif (drive['device'] in ('cdrom', 'floppy') and
Line 307: 'specParams' in drive and
Line 308: # next line can be removed in future, when < 3.3 engine
Line 309: # is not supported
Line 310: drive['specParams'].get('path', '') == '' and
Correct, but note that this should have happened in the master branch, not here.
Unfortunately, it's too late for that. To ovirt-3.3 I'd rather take whatever that is in master.
Line 311: drive.get('path', '') == ''):
Line 312: volPath = ''
Line 313:
Line 314: # ... or load the drive from vmPayload:
--
To view, visit http://gerrit.ovirt.org/22324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list