Change in vdsm[master]: configNetwork: Fix bridgeless broken network deletion

danken at redhat.com danken at redhat.com
Fri Dec 13 17:12:15 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: configNetwork: Fix bridgeless broken network deletion
......................................................................


configNetwork: Fix bridgeless broken network deletion

When trying to delete a broken bridgeless vdsm network, if the iface
referenced by the network definition was missing, delNetwork would
not get any device on its call for vlan, nic and bonds, but
objectivize would be called nonetheless, failing with a:

ERR_BAD_PARAMS: 'Network defined without devices.'

The fix consists on just removing the network from libvirt when the
backing device is missing.

Change-Id: I92c641d91da9ef7eab876ed8c77fff7a9becb503
Bug-Url: https://bugzilla.redhat.com/1020356
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22354
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
M tests/functional/utils.py
M vdsm/configNetwork.py
3 files changed, 33 insertions(+), 0 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92c641d91da9ef7eab876ed8c77fff7a9becb503
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list