Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images

nsoffer at redhat.com nsoffer at redhat.com
Fri Dec 13 13:25:08 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: clientIF: Teardown volume path only for VDSM images
......................................................................


Patch Set 5:

This patch should be rebased on http://gerrit.ovirt.org/22370, which resolve the issues discussed in this patch.

After rebase, calling vm.isVdsmImage(drive) is correct and symmetric to clientIF.prepareVolumePath.

The only issue left to resolve is how to handle None and str types when calling vm.isVdsmImage. This can be handled in either clinetIF.teardownVolumePath or vm.isVdsmImage.

-- 
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list