Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

sgotliv at redhat.com sgotliv at redhat.com
Fri Dec 13 11:33:58 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

I am not sure that all checks are unnecessary therefore I didn't remove them all, such work is very time consuming and requires to perform tests so I decided to do that step by step and this is the first step.

I choose to remove that one first as suggested by Ayal and Federico here: http://gerrit.ovirt.org/#/c/21973/ in order to make "prepare" and "teardown" are symmetric in the manner of how they both are treating the input dictionary type.

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list