Change in vdsm[master]: sp: move reconnection info check to StoragePool

Federico Simoncelli fsimonce at redhat.com
Fri Dec 13 11:00:23 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: sp: move reconnection info check to StoragePool
......................................................................


Patch Set 8:

(3 comments)

....................................................
File vdsm/storage/hsm.py
Line 1028:             pass  # pool not connected yet
Line 1029:         else:
Line 1030:             with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.shared):
Line 1031:                 self.getPool(spUUID).update(hostID, scsiKey, msdUUID,
Line 1032:                                             masterVersion)
Yeah, actually in my latest code (sadly not pushed yet) "update" disappeared completely and I am just using "refresh". (Sorry for wasting your time on describing this).
Line 1033:                 return True
Line 1034: 
Line 1035:         with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.exclusive):
Line 1036:             try:


Line 1040:             else:
Line 1041:                 pool.update(hostID, scsiKey, msdUUID, masterVersion)
Line 1042:                 return True
Line 1043: 
Line 1044:             pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng)
because we use connect at line 1052
Line 1045: 
Line 1046:             # Must register domain state change callbacks *before* connecting
Line 1047:             # the pool, which starts domain monitor threads. Otherwise we will
Line 1048:             # miss the first event from the monitor thread.


....................................................
File vdsm/storage/sp.py
Line 677:             f.writelines(pers)
Line 678: 
Line 679:     @unsecured
Line 680:     def getPoolParams(self, hostID, scsiKey, msdUUID, masterVersion):
Line 681:         if all((hostID, scsiKey, msdUUID, masterVersion)):
noted, please allow another couple of cycles with this behavior and then I'll take care of it.
Line 682:             return hostID, scsiKey, msdUUID, masterVersion
Line 683: 
Line 684:         self.log.info(
Line 685:             "Using saved connection parameters: hostID=%s, scsiKey=%s, "


-- 
To view, visit http://gerrit.ovirt.org/21424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list