Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images

sgotliv at redhat.com sgotliv at redhat.com
Thu Dec 12 13:31:29 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: clientIF: Teardown volume path only for VDSM images
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/clientIF.py
Line 326:     def teardownVolumePath(self, drive):
Line 327:         res = {'status': doneCode}
Line 328: 
Line 329:         if vm.isVdsmImage(drive):
Line 330:             res = self.irs.teardownImage(drive['domainID'],
Michal,

Please, explain your point. 

Before my change code caught only KeyError and TypeError for all other types of errors you won't continue to teardown the next image.

Now when isVdsmImage() is safe from TypeError and KeyError the code is doing the same.
Line 331:                                          drive['poolID'], drive['imageID'])
Line 332:         return res['status']['code']
Line 333: 
Line 334:     def getDiskAlignment(self, drive):


-- 
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list