Change in vdsm[master]: linkmonitor: fix reported device name of vlans and macvlans
asegurap at redhat.com
asegurap at redhat.com
Thu Dec 12 01:53:29 UTC 2013
Antoni Segura Puimedon has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
......................................................................
Patch Set 12:
(1 comment)
....................................................
File lib/vdsm/ipwrapper.py
Line 578: line = line[len(cls._DELETED_TEXT):]
Line 579:
Line 580: ifindex, devName, data = [el.strip() for el in line.split(':', 2)]
Line 581: if (state != cls.LINK_STATE_DELETED and
Line 582: not _dev_sysfs_exists(devName)):
This will delete events referring to no longer existing devices when using the monitor in non continuous operation :-(
Line 583: # devName is probably a vlan device with an '@underlying_dev'
Line 584: # affixed or it might refer to a just deleted link.
Line 585: try:
Line 586: devName = _dev_by_index(ifindex)
--
To view, visit http://gerrit.ovirt.org/22061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaeab6adc30a80b70e9e967768c10b3fea65aa16
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list