Change in vdsm[master]: syncproc: Add blocking mode.
danken at redhat.com
danken at redhat.com
Wed Dec 11 18:46:41 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: syncproc: Add blocking mode.
......................................................................
Patch Set 9:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 345: else:
Line 346: return res
Line 347:
Line 348: def read(self, length):
Line 349: if not self._parent.blocking:
Toni, I suppose that you're right, though you've forgotten to drop the "not" in the condition.
Nevertheless, I want blocking read() NOW!
Line 350: return self._readNonBlock(length)
Line 351: else:
Line 352: res = None
Line 353: while res is None:
--
To view, visit http://gerrit.ovirt.org/21897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id406249bfd63f59f273d27614a38a43595f1d7e1
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list