Change in vdsm[master]: asyncproc: Removed the close count.

danken at redhat.com danken at redhat.com
Wed Dec 11 18:35:07 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: asyncproc: Removed the close count.
......................................................................


asyncproc: Removed the close count.

When I originally wrote the class I assumed that since the process side
FD is closed I should mark it closed on VDSMs side as well.

This appeared to be problematic as stuff in the python infrastructure
don't like it when I autoclose the FD for them.

I partially solved it by adding the close counter so that things don't
crash because they don't expect the FD to get closed while they are
reading even if they got EOF.

But since closing the FD doesn't really need to be reflected in the
stream I now decided it's better to just leave it marked as open in the
stream wrapper. The real FD is managed by AsyncProc so there is no worry
about an FD leak.

I just remove the close count buffer and never mark the FD as closed an
leave it up to the user. We loose the ability to detect a stream closing
without waiting for an empty string but that is how python wants you to
do it and this is how we will.

Change-Id: Iaa3bbe8409d0cb0591555e595b3202e9e01c0db4
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22243
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Antoni Segura Puimedon <asegurap at redhat.com>
---
M lib/vdsm/utils.py
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa3bbe8409d0cb0591555e595b3202e9e01c0db4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list